Deprecate XCMv2#4131
Merged
Merged
Conversation
bkontur
reviewed
Apr 16, 2024
bkontur
approved these changes
May 23, 2024
Contributor
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
I added some suggestions/nits to avoid using concrete XCM versions where not needed, so we don't need to do this again with newer versions
…idge-hub-rococo/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-rococo/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-rococo/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-rococo/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-rococo/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-westend/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-westend/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-westend/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-westend/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…idge-hub-westend/src/tests/send_xcm.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
franciscoaguirre
requested review from
acatangiu,
ggwpez,
liamaharon and
serban300
svyatonik
approved these changes
May 27, 2024
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/psa-xcmv2-deprecation/8367/1 |
hitchho
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
Marked XCMv2 as deprecated now that we have XCMv4. It will be removed sometime around June 2024. --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Marked XCMv2 as deprecated now that we have XCMv4. It will be removed sometime around June 2024. --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com>
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked XCMv2 as deprecated now that we have XCMv4.
It will be removed sometime around June 2024.